gh-151866: Remove unneeded zlib dependency in zipfile tests#135631
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
This PR is stale because it has been open for 30 days with no activity. |
`zipfile.crc32` is internally `zlib.crc32` and fallbacks to `binacsii.crc32` when `zlib.crc32` is not available. Both of them do the same task. `create_zipfile_with_extra_data` only calls `crc32` and does not actually require the decompression method provided by `zlib`. Use `zipfile.crc32` rather than `zlib.crc32` to allow the test to run on platforms without `zlib` support.
danny0838
force-pushed
the
fix-unneeded-zlib
branch
from
51a2221 to
6bc61b7
Compare
danny0838
force-pushed
the
fix-unneeded-zlib
branch
from
788a6bd to
e1f43de
Compare
StanFromIreland
changed the title
zlib dependency in zipfile testszlib dependency in zipfile tests
This reverts commit e1f43de.
github-actions
Bot
removed
the
stale
Member
|
Looks like I'm playing the TSan CI lotto today :'-( |
Member
|
Merged, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
zipfile.crc32rather thanzlib.crc32since it can work withoutzlib.