Set VIRTUALENVWRAPPER_SCRIPT portably

[ferdnyc]

• ${.sh.file} was ksh syntax, but ksh support was dropped in commit d736549
• Instead of testing only for certain specific shells (and excluding all others), use $BASH_SOURCE if it's set, otherwise fall back to $0 which should work with more shells (hopefully).

Fixes #105

[ferdnyc]

(Note: I don't know that this will make virtualenvwrapper WORK with the ash shell (from #105), that depends how it handles $0 in sourced scripts. But it will at least make it stop crashing the script when it tries to source it, because it hits the KSH syntax that's currently being used as the default.)

[dhellmann]

Some of the bash versions in the test matrix don't seem to like the new syntax. I see lots of errors like:

/Users/runner/work/virtualenvwrapper/virtualenvwrapper/.tox/py/bin/virtualenvwrapper.sh: line 99: ${$BASH_SOURCE:-}: bad substitution

[dhellmann]

It also looks like even though we said we dropped zsh support there is still a test job for it.

[ferdnyc]

Some of the bash versions in the test matrix don't seem to like the new syntax. I see lots of errors like:

/Users/runner/work/virtualenvwrapper/virtualenvwrapper/.tox/py/bin/virtualenvwrapper.sh: line 99: ${$BASH_SOURCE:-}: bad substitution

Oh, crap! Not surprised, that's a really dumb typo. It should be ${BASH_SOURCE:-}. Whoops. I'll fix that, thanks.

Maybe I had Fish on the brain. {$BASH_SOURCE}, REALLY???

[ferdnyc]

@dhellmann Fixed now, sorry about that.

[ferdnyc]

It also looks like even though we said we dropped zsh support there is still a test job for it.

Zsh is still supported, I think? The $0 there is specifically for Zsh, though I hope it will work in some other shells as well.

It's Ksh that support was dropped for, and their crazy ${.sh.file} was never going to work for any other shell so it was the worst possible default.

[ferdnyc]

@dhellmann #118 will fix those readthedocs failures.

[dhellmann]

It also looks like even though we said we dropped zsh support there is still a test job for it.

Zsh is still supported, I think? The $0 there is specifically for Zsh, though I hope it will work in some other shells as well.

It's Ksh that support was dropped for, and their crazy ${.sh.file} was never going to work for any other shell so it was the worst possible default.

Wow, yes, you're right. I completely conflated ksh and zsh in my head.

[dhellmann]

@Mergifyio rebase

[mergify]

rebase

✅ Branch has been successfully rebased