Fix poetry installer with homebrew python on MacOS#133
Closed
yuriyostapenko wants to merge 2 commits intopython-poetry:mainfrom
yuriyostapenko:fix-relative-symlink
Closed
Fix poetry installer with homebrew python on MacOS#133yuriyostapenko wants to merge 2 commits intopython-poetry:mainfrom yuriyostapenko:fix-relative-symlink
yuriyostapenko wants to merge 2 commits intopython-poetry:mainfrom
yuriyostapenko:fix-relative-symlink
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…latest version of poetry (1.6.1), and install will always fail
|
Any movements here? Using |
|
Is there any reason this wasn't merged/reviewed by a maintainer? the code looks reasonable and brew & poetry is a recipe for pain until this is addressed |
Member
|
@yuriyostapenko if you are still interested in this change making into the script, can you fix the conflicts (drop the matrix update commit) and add a new job similar to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change will detect when
sys.executableis a relative symlink and avoid copying such symlink, as it would be broken in a new location.UPDATE: Removed python 3.7 from matrix job, since it is no longer supported by latest poetry (1.6.1 as of today).
Fixes #24, #51.