Fix incomplete license header in src/libImaging/Arrow.h#9787
Open
muhamedfazalps wants to merge 3 commits into
Open
Fix incomplete license header in src/libImaging/Arrow.h#9787muhamedfazalps wants to merge 3 commits into
muhamedfazalps wants to merge 3 commits into
Conversation
Member
|
#9657 (comment) Specifies the exact source of the code, and its not arrow_abi.h. |
The vendored Arrow C Data Interface code comes from the documentation page, not the Arrow source repository. Update the source URL to match. Fixes python-pillow#9657
muhamedfazalps
force-pushed
the
fix-arrow-license-header
branch
from
592d309 to
3a3d107
Compare
for more information, see https://pre-commit.ci
The 'Only' keyword was accidentally merged with the URL line. Separate it onto its own line for readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the incomplete license header in
src/libImaging/Arrow.has reported in #9657.Problem
The file
src/libImaging/Arrow.his vendored from Apache Arrow'sabi.h(source), but only contained a minimal license comment:This does not satisfy the Apache 2.0 license requirements, which mandate inclusion of the full ASF license boilerplate for files derived from ASF-licensed projects.
Fix
Replace the minimal header with the standard Apache 2.0 license notice exactly as it appears in the original Arrow abi.h, and add a comment clarifying the vendoring origin.
Changes
src/libImaging/Arrow.h: Replaced the short license comment block with the full ASF Apache 2.0 license header and added a vendoring source annotation.No code or logic changes — this is a license-header-only fix.