Skip to content

Don't define class-scoped fixtures as instance methods #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cjwatson wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't define class-scoped fixtures as instance methods #1207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions tests/unit/templating/test_media_types_finders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,21 @@

class TestMediaTypes:
@pytest.fixture(scope="class")
def spec(self):
@classmethod
def spec(cls):
return {
"application/json": {"schema": {"type": "object"}},
"text/*": {"schema": {"type": "object"}},
}

@pytest.fixture(scope="class")
def content(self, spec):
@classmethod
def content(cls, spec):
return SchemaPath.from_dict(spec)

@pytest.fixture(scope="class")
def finder(self, content):
@classmethod
def finder(cls, content):
return MediaTypeFinder(content)

@pytest.mark.parametrize(
Expand Down
9 changes: 6 additions & 3 deletions tests/unit/templating/test_responses_finders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@

class TestResponses:
@pytest.fixture(scope="class")
def spec(self):
@classmethod
def spec(cls):
return {
"200": mock.sentinel.response_200,
"299": mock.sentinel.response_299,
Expand All @@ -17,11 +18,13 @@ def spec(self):
}

@pytest.fixture(scope="class")
def responses(self, spec):
@classmethod
def responses(cls, spec):
return SchemaPath.from_dict(spec)

@pytest.fixture(scope="class")
def finder(self, responses):
@classmethod
def finder(cls, responses):
return ResponseFinder(responses)

def test_default(self, finder, responses):
Expand Down