Add InjectorConfig to control explicit injection behavior#85
Draft
jonathanmach wants to merge 1 commit intopython-injector:masterfrom
Draft
Add InjectorConfig to control explicit injection behavior#85jonathanmach wants to merge 1 commit intopython-injector:masterfrom
jonathanmach wants to merge 1 commit intopython-injector:masterfrom
Conversation
jonathanmach
commented
Nov 19, 2024
| T = TypeVar('T', LocalProxy, Callable) | ||
|
|
||
|
|
||
| class InjectorConfig: |
Author
There was a problem hiding this comment.
Alternatively we could use a dataclass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jstasiak, just raising this to get some initial thoughts from you (before I continue making progress on this).
I imagined that #83 could be implemented via something like:
I also introduced a
InjectorConfigobject that gets passed around. I decided to go with a proper class instead of a flag in case you need to introduce additional config params in the future.(alternatively I could've made
wrap_fun()a method of FlaskInjector? And keep InjectorConfig as a state in FlaskInjector )I'm keen to hear if you'd prefer it implemented in a different way. Let me know!