Open
Conversation
f9f92c0 to
7c8f9b5
Compare
Member
|
I'm good with this; I was somewhat lazy in the past about it. Backwards compatibility should be fine, right? |
Contributor
Author
@Tinche yes. Only possible breakages would be from some inane strict equality checks on |
Tinche
approved these changes
Mar 1, 2026
hynek
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise a new
CattrsErrorinstead of built-inException, and make all other exceptions inherit from this.This makes it more reliable to catch validation issues due to invalid literal or date-time values when structuring (instead of having to parse the exception message when catching
Exception).