Fix scope resolution for parametrized fixtures using dict order#14070
Open
joddeepesh-cloud wants to merge 3 commits intopytest-dev:mainfrom
Open
Fix scope resolution for parametrized fixtures using dict order#14070joddeepesh-cloud wants to merge 3 commits intopytest-dev:mainfrom
joddeepesh-cloud wants to merge 3 commits intopytest-dev:mainfrom
Conversation
psf-chronographer
bot
added
the
bot:chronographer:provided
Author
|
Hi maintainers, this PR fixes #13503 by ensuring correct scope resolution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13503
When all parametrized arguments are indirect, pytest determines the
narrowest scope from the fixtures involved. If fixture definitions
are provided as a dict, the previous logic could select an incorrect
scope.
This change ensures the correct scope is selected by using the last
fixture definition associated with each argument.