Merged
Conversation
Contributor
|
Does this supersede #19 ? I see similar changes here as well. |
Collaborator
Author
No, it simply includes those earlier commits because it's based off that branch. |
dhoomakethu
approved these changes
Aug 12, 2024
Contributor
|
@alexrudd2 , Are these jobs expected to fail? |
Collaborator
Author
|
No, they were passing when I made the PR but something broke with poetry. I'll look into it; should be an easy fix |
Contributor
|
closes #3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress towards #3. This adds
ruff,mypy, andpytest. (but doesn't do any fancy caching like #9)Note this is based off the
ruffbranch becausemaincurrently has lint and type errors.