Do not duplicate outer inputs when inlining OFG#2147
Merged
Conversation
ricardoV94
force-pushed
the
ofg_inline_duplication
branch
2 times, most recently
from
76c7738 to
cd0b0a2
Compare
ricardoV94
commented
May 19, 2026
| """Convert a dense matrix to a sparse matrix.""" | ||
|
|
||
| __props__ = () | ||
| __props__ = ("format",) |
Member
Author
There was a problem hiding this comment.
This showed up during node.op deduplication in rebuild_collect_shared. We were mixing distinct SparseFromDense
ricardoV94
force-pushed
the
ofg_inline_duplication
branch
from
cd0b0a2 to
362404f
Compare
jessegrabowski
approved these changes
May 20, 2026
Member
jessegrabowski
left a comment
jessegrabowski
left a comment
There was a problem hiding this comment.
love it, big improvement from what we had. Looks like the only Op that's still doing the "dual graph" hack is scan?
Member
Author
|
I think OFG Scan and Minimize still on the list |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2142
Address several points from #2033 (I've check marked them now)
This showed up in pymc-devs/pymc-extras#680 where we were duplicating Scans because of the bad (and useless) clone_replace when inlining OFGs
This was not a correctness issue (confirm by late regression test from #2143) but is wasteful / can blowup the graph for no reason.