Skip to content

Replace PermuteRowElements Op with symbolic graph#1928

Open
alessandrogentili001 wants to merge 5 commits intopymc-devs:v3from
alessandrogentili001:remove-permute-row-elements-op
Open

Replace PermuteRowElements Op with symbolic graph#1928
alessandrogentili001 wants to merge 5 commits intopymc-devs:v3from
alessandrogentili001:remove-permute-row-elements-op

Conversation

@alessandrogentili001
Copy link

Description

  • permute_row_elements() now uses take_along_axis + argsort
  • inverse_permutation() simplified to cast(argsort(perm), perm.dtype)
  • class PermuteRowElements deleted entirely"

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

@ricardoV94
Copy link
Member

Let's just remove this Op (no helper even)

return PermuteRowElements(inverse=inverse)(x, y)


def inverse_permutation(perm):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should also be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants