Change default cast_policy to numpy+floatX to fix float downcasting#1917
Draft
ayulockedin wants to merge 1 commit intopymc-devs:mainfrom
Draft
Change default cast_policy to numpy+floatX to fix float downcasting#1917ayulockedin wants to merge 1 commit intopymc-devs:mainfrom
ayulockedin wants to merge 1 commit intopymc-devs:mainfrom
Conversation
Contributor
Author
|
i have changed the default to see what the damage cuz i think all tests would also be relying on the old |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the default
cast_policyinconfigdefaults.pytonumpy+floatX. This removes the olderNumpyAutocastermachinery which was causing inconsistent float downcasting (e.g., downcasting9.0tofloat32while keeping8.9and9.1asfloat64).Opening this as a draft PR first to let the CI test suite evaluate the overall impact. Changing this core default will likely require updating type assertions across the broader test suite where the old downcasting behavior was explicitly expected.
Related Issue
Checklist
Type of change