Fix --help consumed as positional arg value#1059
Open
Fridayai700 wants to merge 1 commit intopyinvoke:mainfrom
Open
Fix --help consumed as positional arg value#1059Fridayai700 wants to merge 1 commit intopyinvoke:mainfrom
Fridayai700 wants to merge 1 commit intopyinvoke:mainfrom
Conversation
When a task has required positional arguments, `--help` was being eaten as a positional arg value instead of being recognized as the help flag. This happened because the positional-args elif branch came before the initial-context flags check. Fix by reordering the elif chain so initial-context flags (like --help) are checked before positional args. Also skip positional arg validation in complete_context() when --help was requested, since the user is asking for help, not trying to invoke the task.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--helpafter the command treats--helpas positional argument #982--helpafter the task name was consumed as the positional arg's value instead of being recognized as the help flagParseMachine.handle(), the positional-argselifbranch came before the initial-context flags check, so--helpwas eaten as a positional valueelifchain so initial-context flags are checked before positional args, and skip positional arg validation when--helpwas requestedTest plan
--help→ help flag is set, not consumed as positional valuetests/runners.py)