Closed
Conversation
Member
Author
|
This no longer works. Since updating Pybricks Code, it looks like we are now always sending 0 for the slot payload, so using the "current slot" never hits. case PBIO_PYBRICKS_COMMAND_START_USER_PROGRAM: {
if (size > 2) {
return PBIO_PYBRICKS_ERROR_VALUE_NOT_ALLOWED;
}
// Use payload as program ID, otherwise use active user slot.
return pbio_pybricks_error_from_pbio_error(
pbsys_main_program_request_start((size == 2 ? data[1] : pbsys_hmi_get_selected_program_slot()), PBSYS_MAIN_PROGRAM_START_REQUEST_TYPE_REMOTE));I suppose it is not critical since we are not shipping this with the current firmware. |
Member
Author
This can be solved with pybricks/pybricks-code#2343 |
Member
Author
|
Closing since we enabled #312. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for basic multi-program slots has been added a while ago, but it is not enabled by default while we wait on related featured to be completed.
This enables it for those who wish to try it out early.
Try it out
Caveats