Add temperature model comparison example#2696
Closed
aman-coder03 wants to merge 3 commits intopvlib:mainfrom
Closed
Add temperature model comparison example#2696aman-coder03 wants to merge 3 commits intopvlib:mainfrom
aman-coder03 wants to merge 3 commits intopvlib:mainfrom
Conversation
Member
|
@aman-coder03 pvlib is developed by solar energy modelers and is a difficult project for general programmers to get involved with. For a gallery example to be meaningful, the contributor needs to have insight into solar energy modeling (ideally some experience with using pvlib) for the example to be meaningful. While the gallery example you propose is technically correct, it does not go into the technical details behind the temperature models to discuss why they differ. Unfortunately, our reviewer capacity is limited and we cannot accept PRs from people without solar experience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ModelChain#2695docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.This PR adds a new Sphinx-gallery example under
docs/examples/iv-modelingthat compares SAPM, Faiman, and PVsyst temperature models using identical environmental inputs