Add support for pulp_labels key to file_repository#244
Merged
Conversation
philnewm
commented
May 17, 2026
| module.fail_json(msg="pulp_labels must be a dictionary with strings as keys and values") | ||
| module.fail_json( | ||
| msg="pulp_labels must be a dictionary with strings as keys and values" | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
Adjusted the rpm_repository formatting as well to make the linter happy
mdellweg
previously approved these changes
May 18, 2026
Member
|
Looks like there is a new type of vcr incompatibility with python 3.14.? Can you look into maybe recording with a different version (I don't know exactly what the compatibility claim for that format is...)? |
Contributor
Author
|
Sure, I'll take a closer look at the failing python3.14 tests later today |
philnewm
force-pushed
the
file-repo-pulp-labels
branch
3 times, most recently
from
d1c0ca3 to
f10714b
Compare
philnewm
commented
May 18, 2026
philnewm
force-pushed
the
file-repo-pulp-labels
branch
from
b46e6ac to
16ad9e1
Compare
mdellweg
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #243
Adds the pulp_labels parameter to the file_repository module and extends the tests based on the ones from rpm_repository.