Added maxSeconds prop, where timer starts or 'started'#22
Open
Zarux wants to merge 2 commits intopughpugh:masterfrom
Open
Added maxSeconds prop, where timer starts or 'started'#22Zarux wants to merge 2 commits intopughpugh:masterfrom
Zarux wants to merge 2 commits intopughpugh:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a prop to tell where the timer should start or where it "originally started".
<ReactCountdownClock seconds={30} maxSeconds={60} />Will have the timer started halfways.
<ReactCountdownClock seconds={60} maxSeconds={30} />Will not animate until 30 seconds left
Fiddle (converted to js): https://jsfiddle.net/6wgjyqyk/
Video example
I use the timer in a multiplayer game, and when a new client joins there is no way to display how much time has passed, only how much is left. This feature would help with that.