Skip validate-release gate in smoke builds (fixes main-base PR CI)#202
Open
ptr727 wants to merge 2 commits into
Open
Skip validate-release gate in smoke builds (fixes main-base PR CI)#202ptr727 wants to merge 2 commits into
ptr727 wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the reusable build-release-task workflow so PR smoke builds don’t fail the validate-release entry gate when the build is running from a detached HEAD (which causes NBGV to report a prerelease version even for main-base PRs). This keeps develop → main promotion PRs with library changes from being blocked by their own required smoke CI.
Changes:
- Adds a
SMOKEenvironment value derived frominputs.smokein thevalidate-releasestep. - Skips the branch/version validation gate when
smoke: true, while keeping the job successful so downstreamneedsremain satisfied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem (found via end-to-end flow validation)
The
validate-releaseentry gate runs unconditionally, including in PR smoke builds. A smoke build checks out the PR head in detached HEAD, so NBGV always computes a prerelease version (X.Y.Z-g<sha>). For a main-base PR (adevelop→mainpromotion carrying a build target), the gate then fails:→ the required
Check pull request workflow statusfails → everydevelop→mainpromotion PR with library changes is blocked by its own smoke build. (Masked previously because #197 was admin-bypass-merged due to a conflict.)Fix
The gate guards real publishes; smoke builds never publish. Skip it for smoke (keeping the job in the graph so
build-nugetlibrary'sneedsstays satisfied).Verified in CI
A push-probe invoking
build-release-taskwithsmoke: true:Before the fix, the main-base
validate-releasefailed (confirmed via a real main-base PR smoke build, #201).🤖 Generated with Claude Code