Skip to content

Skip validate-release gate in smoke builds (fixes main-base PR CI)#202

Open
ptr727 wants to merge 2 commits into
developfrom
fix/validate-release-skip-smoke
Open

Skip validate-release gate in smoke builds (fixes main-base PR CI)#202
ptr727 wants to merge 2 commits into
developfrom
fix/validate-release-skip-smoke

Conversation

@ptr727

@ptr727 ptr727 commented Jun 27, 2026

Copy link
Copy Markdown
Owner

Problem (found via end-to-end flow validation)

The validate-release entry gate runs unconditionally, including in PR smoke builds. A smoke build checks out the PR head in detached HEAD, so NBGV always computes a prerelease version (X.Y.Z-g<sha>). For a main-base PR (a develop→main promotion carrying a build target), the gate then fails:

::error::Public (main) release version '1.4.4-g901404c71a' carries a prerelease suffix; refusing to publish.

→ the required Check pull request workflow status fails → every develop→main promotion PR with library changes is blocked by its own smoke build. (Masked previously because #197 was admin-bypass-merged due to a conflict.)

Fix

The gate guards real publishes; smoke builds never publish. Skip it for smoke (keeping the job in the graph so build-nugetlibrary's needs stays satisfied).

Verified in CI

A push-probe invoking build-release-task with smoke: true:

base validate-release build publish
main success (skipped) Release ✅ github-release skipped
develop success (skipped) Debug ✅ github-release skipped

Before the fix, the main-base validate-release failed (confirmed via a real main-base PR smoke build, #201).

🤖 Generated with Claude Code

ptr727 and others added 2 commits June 26, 2026 17:09
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 27, 2026 00:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the reusable build-release-task workflow so PR smoke builds don’t fail the validate-release entry gate when the build is running from a detached HEAD (which causes NBGV to report a prerelease version even for main-base PRs). This keeps develop → main promotion PRs with library changes from being blocked by their own required smoke CI.

Changes:

  • Adds a SMOKE environment value derived from inputs.smoke in the validate-release step.
  • Skips the branch/version validation gate when smoke: true, while keeping the job successful so downstream needs remain satisfied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants