Conversation
NBGV's GitHub Actions provider reads the reserved GITHUB_REF (which a step env cannot override); set IGNORE_GITHUB_REF=true so it versions from the checked-out branch instead. Supersedes the ineffective GITHUB_REF override from #196. CI-verified: develop checkout -> 1.4.x-g<sha> prerelease, main -> stable. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Promotes the develop branch to main to ship the workflow change from #198 that fixes NBGV prerelease tagging in the publish matrix by using IGNORE_GITHUB_REF instead of attempting to override reserved GITHUB_REF.
Changes:
- Updates
get-version-task.ymlto setIGNORE_GITHUB_REF=truefordotnet/nbgv@masterand removes the previously threadedbranchinput. - Removes
branchpassthrough toget-version-task.ymlfrom the reusable build workflows (build-release-task.yml,build-nugetlibrary-task.yml).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/get-version-task.yml | Switch NBGV ref detection to IGNORE_GITHUB_REF and drop the branch input. |
| .github/workflows/build-release-task.yml | Stops passing branch into the version-task call. |
| .github/workflows/build-nugetlibrary-task.yml | Stops passing branch into the version-task call. |
Smoke builds check out the PR head detached, so NBGV always yields a prerelease version; on a main-base PR that tripped validate-release and blocked every develop->main promotion carrying a build target. Skip the gate for smoke builds (they never publish). CI-verified for both main and develop bases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
build-nugetlibrary checks out a pinned SHA (detached HEAD), where NBGV with IGNORE_GITHUB_REF saw no branch and built the main leg's package as a prerelease mismatching its clean release tag. Re-add the branch input + git checkout -B <branch> so NBGV sees the logical branch from a detached SHA. CI-verified: main->1.4.3.nupkg (clean), develop->1.4.4-g<sha>.nupkg (prerelease). Caught by Copilot on the promotion PR. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes
developtomainto deploy the corrected prerelease-tagging fix (#198) so the next publish exercises it.IGNORE_GITHUB_REF=truemakes NBGV version from the checked-out branch (the priorGITHUB_REFoverride from Re-sync release-workflow fixes from template (#213/#214) #196 was ineffective — reserved var). CI-verified: develop checkout →1.4.x-g<sha>prerelease, main → stable.Merge commit (not squash). A
publish-release.ymldispatch after this lands will confirm the develop leg publishes a true pre-release.🤖 Generated with Claude Code