fix: [libpthreadglue] tighten error handling in OS-abstraction layer#840
Merged
uyjulian merged 1 commit intoMay 11, 2026
Merged
Conversation
pte_osThreadCreate previously: - called CreateThread with a stack pointer that hadn't been validated, then NULL-checked it afterwards - wrote into __threadInfo[threadId] before checking whether threadId was negative — a CreateThread failure caused an OOB write - ignored the return value of CreateSema for cancelSem - on cleanup paths, leaked the cancelSem semaphore and the stack allocation Reorder so each resource is validated immediately after allocation and cleaned up in reverse order on failure. Also propagate CreateSema failures from pte_osMutexCreate and pte_osSemaphoreCreate as PTE_OS_NO_RESOURCES instead of returning a negative handle as if it were valid. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pte_osThreadCreateused to malloc the stack and callCreateThread, then NULL-check the stack and checkthreadId < 0after__threadInfo[threadId]was already written — a negative id caused an OOB write. The check for thecancelSemsemaphore was also missing, and the failure paths leakedcancelSemand the stack.CreateSemafailures frompte_osMutexCreateandpte_osSemaphoreCreateasPTE_OS_NO_RESOURCESinstead of returning a negative handle through*pHandleas if it were a valid semaphore.Related
mutex9test referenced in the test plan.Test plan
ee/libpthreadgluecleanly.