Fix mingw32 build: cast setsockopt optval to const char *#23
Merged
Conversation
On Windows, the Winsock setsockopt prototype takes `const char *optval`, not `const void *` like POSIX. Passing `&one` (int *) breaks the mingw32 build with -Wincompatible-pointer-types. Cast to (const char *) so it compiles on both POSIX and Winsock. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setsockopt(..., TCP_NODELAY, &one, sizeof(one))call that breaks the mingw32 build because Winsock'ssetsockoptprototype takesconst char *optval(notconst void *like POSIX).(const char *)cast — harmless on POSIX, required on Windows.This is what currently fails CI on
windows-latestin the ps2dev meta build:Test plan
optvalisconst void *)🤖 Generated with Claude Code