Remove num_headers and use status_code in responses instead.#104
Open
PiotrSikora wants to merge 1 commit into
Open
Remove num_headers and use status_code in responses instead.#104PiotrSikora wants to merge 1 commit into
num_headers and use status_code in responses instead.#104PiotrSikora wants to merge 1 commit into
Conversation
Signed-off-by: Piotr Sikora <code@piotrsikora.dev>
leonm1
reviewed
May 21, 2026
| - `i32 (size_t) status_code` | ||
| - `i32 (size_t) body_size` | ||
| - `i32 (size_t) num_trailers` | ||
| - `i32 (size_t) has_trailers` |
Contributor
There was a problem hiding this comment.
Does proxy_get_header_map_pairs support "has" semantics by passing NULL for a return buffer pointer? If so, we don't need has_trailers.
Member
Author
There was a problem hiding this comment.
The point of those hints is to avoid the expensive call across the host<>Wasm boundary when not needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.