-
Notifications
You must be signed in to change notification settings - Fork 3
fix(deps): update react monorepo to v19 (major) #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,13 +10,13 @@ | |
| }, | ||
| "dependencies": { | ||
| "@excalidraw/excalidraw": "0.17.6", | ||
| "react": "^18.2.0", | ||
| "react-dom": "^18.2.0", | ||
| "react": "^19.0.0", | ||
| "react-dom": "^19.0.0", | ||
| "socket.io-client": "^4.8.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/react": "^18.2.0", | ||
| "@types/react-dom": "^18.2.0", | ||
| "@types/react": "^19.0.0", | ||
| "@types/react-dom": "^19.0.0", | ||
|
Comment on lines
+18
to
+19
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This change updates dependency declarations to React 19 but does not update Useful? React with 👍 / 👎. |
||
| "@vitejs/plugin-react": "^6.0.0", | ||
| "typescript": "^6.0.0", | ||
| "vite": "^8.0.5" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@excalidraw/excalidrawremains at0.17.6, but its declared peer range inplugins/draw/ui/package-lock.jsonisreact/react-dom ^17.0.2 || ^18.2.0, so bumping this package toreact/react-dom^19.0.0introduces a peer-version conflict. This affects the draw plugin install/build path (plugins/draw/package.jsonrunscd ui && npm install), which now resolves with peer overrides and can fail under strict peer resolution; either upgrade Excalidraw to a React 19-compatible release or keep React on 18 here.Useful? React with 👍 / 👎.