Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/draw/ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@
},
"dependencies": {
"@excalidraw/excalidraw": "0.17.6",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react": "^19.0.0",
"react-dom": "^19.0.0",
Comment on lines +13 to +14
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep Excalidraw and React majors compatible

@excalidraw/excalidraw remains at 0.17.6, but its declared peer range in plugins/draw/ui/package-lock.json is react/react-dom ^17.0.2 || ^18.2.0, so bumping this package to react/react-dom ^19.0.0 introduces a peer-version conflict. This affects the draw plugin install/build path (plugins/draw/package.json runs cd ui && npm install), which now resolves with peer overrides and can fail under strict peer resolution; either upgrade Excalidraw to a React 19-compatible release or keep React on 18 here.

Useful? React with 👍 / 👎.

"socket.io-client": "^4.8.0"
},
"devDependencies": {
"@types/react": "^18.2.0",
"@types/react-dom": "^18.2.0",
"@types/react": "^19.0.0",
"@types/react-dom": "^19.0.0",
Comment on lines +18 to +19
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Regenerate ui lockfile after React major bump

This change updates dependency declarations to React 19 but does not update plugins/draw/ui/package-lock.json, whose root package entry still pins react, react-dom, @types/react, and @types/react-dom to ^18.2.0 (lines 10-18 in the lockfile). That leaves the checked-in dependency graph inconsistent, so installs that honor the lockfile do not actually reproduce the intended React 19 upgrade.

Useful? React with 👍 / 👎.

"@vitejs/plugin-react": "^6.0.0",
"typescript": "^6.0.0",
"vite": "^8.0.5"
Expand Down
Loading