fix: handle multi-type Accept headers in parseOpenMetricsVersion#1987
Merged
jaydeluca merged 1 commit intoprometheus:content-negotiation-flagfrom Mar 30, 2026
Merged
Conversation
…ader parseOpenMetricsVersion was splitting the entire Accept header by ";" which meant version parameters from other media types (e.g. text/plain; version=0.0.4) could be incorrectly attributed to openmetrics-text. Now splits by "," first to isolate individual media types, finds the openmetrics-text entry, then parses only its parameters for version. Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
jaydeluca
approved these changes
Mar 30, 2026
Collaborator
jaydeluca
left a comment
jaydeluca
left a comment
There was a problem hiding this comment.
you could've left a code review comment and I could have done this, but thanks!
jaydeluca
merged commit b15d16e
into
prometheus:content-negotiation-flag
13 checks passed
jaydeluca
pushed a commit
that referenced
this pull request
Mar 30, 2026
Signed-off-by: Jay DeLuca <jaydeluca4@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parseOpenMetricsVersioncould pick upversionparameters from unrelated media types in multi-type Accept headers (e.g.application/openmetrics-text, text/plain; version=0.0.4),first to isolate individual media types before parsing parametersTest plan
ExpositionFormatsTesttests passtext/plainhas version → OM1 writer selectedversion=2.0.0→ OM2 writer selected