Fix loadImage SVG file loading regression#8937
Open
gfrancine wants to merge 4 commits into
Open
Conversation
19 tasks
gfrancine
force-pushed
the
main
branch
3 times, most recently
from
e64954a to
660f9ab
Compare
gfrancine
changed the title
loadImageloadImage
gfrancine
changed the title
loadImageloadImage SVG file loading regression
gfrancine
changed the title
loadImage SVG file loading regressionloadImage SVG file loading regression
Continuous ReleaseCDN linkPublished PackagesCommit hash: b26caed Previous deploymentsThis is an automated message. |
…map` `createImageBitmap` throws when loading vector images -- revert to initial `loadImage` implementation pre- commit e43f709 See https://html.spec.whatwg.org/multipage/imagebitmap-and-animations.html#dom-createimagebitmap
The pre-v2.0 implementation, which loadImage was reverted to, requests the same image twice. Use the fetched blob data instead
Author
|
Tiny important edit: the old implementation that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8921
Changes:
Load images with
HTMLImageElementinstead ofcreateImageBitmap.Reverts to the
loadImageimplementation in p5.js <v2.0 (pre- commit e43f709, which introduced the regression).createImageBitmapcannot load vector images and will reject with anInvalidStateError.Further reading:
PR Checklist
npm run lintpasses