fix: preserve locale casing in content collection entry IDs#1447
Open
lirenjie95 wants to merge 1 commit into
Open
fix: preserve locale casing in content collection entry IDs#1447lirenjie95 wants to merge 1 commit into
lirenjie95 wants to merge 1 commit into
Conversation
lirenjie95
force-pushed
the
fix/content-entry-id-locale-casing
branch
from
c54c07b to
13af1c0
Compare
Collaborator
|
Hi @lirenjie95, thank you for the PR. Tested this locally and can confirm the fix works, Chinese translations now load correctly after switching language. Placing generateEntryId in shared.ts is the right call, that file already holds shared utilities used across collections. One place to maintain, all 12 collections benefit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1446
The original issue was introduced in #1409