Enforce node version >= 22 for npm install#1234
Open
nbogie wants to merge 6 commits intoprocessing:2.0from
Open
Enforce node version >= 22 for npm install#1234nbogie wants to merge 6 commits intoprocessing:2.0from
nbogie wants to merge 6 commits intoprocessing:2.0from
Conversation
Contributor
Author
|
Website CI was using node v20 by default (it's not specified). I've updated it to explicitly use v22 for all steps in test.yml so far, which lets this PR pass. Performance note: It'll be worth comparing the CI elapsed run-times for this PR against others to check it is no slower than when it was using the default from update: from the log, this is a good sign: |
This reverts commit 9a30d3b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1233
package.jsonengine-strict=truedocs/technical_overview.md.As a result, npm install with a sub-22 version of node.js will give the following format of error:
why not devEngines?
Whilst devEngines is a good solution in future, it will be ignored by older platforms.