Fixed the "edit source" links on p5.sound reference pages (beta.p5js.org) to point to the correct repository.#1074
Closed
Linqi1234 wants to merge 2 commits intoprocessing:2.0from
Closed
Fixed the "edit source" links on p5.sound reference pages (beta.p5js.org) to point to the correct repository.#1074Linqi1234 wants to merge 2 commits intoprocessing:2.0from
Linqi1234 wants to merge 2 commits intoprocessing:2.0from
Conversation
Linqi1234
changed the title
Member
|
Hi, I wll close this as the original problem was resolved by a different fix. Sorry this slipped through. Please note in the contributor guidelines we ask that before making an PR, each volunteer gets assigned on the issue and their approach approved. This helps to avoid accidental duplicate work. I recommend starting with issue in the future . Thanks for understanding! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the "edit source" links on p5.sound reference pages (beta.p5js.org) to point to the correct repository.
Problem
The source links on p5.sound reference pages were pointing to
processing/p5.js, which resulted in 404 errors. For example:https://github.com/processing/p5.js/blob/v2.1.2/src/sources/AudioIn.js(404)Solution
Added a conditional check: when
entry.data.module === 'p5.sound', the link now points toprocessing/p5.sound.jsrepository with themainbranch:https://github.com/processing/p5.sound.js/blob/main/src/sources/AudioIn.js