fix(client): show toast notifications on file/folder rename validatio…#4177
Open
Dakshx07 wants to merge 1 commit into
Open
fix(client): show toast notifications on file/folder rename validatio…#4177Dakshx07 wants to merge 1 commit into
Dakshx07 wants to merge 1 commit into
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Fixes #4176
Description:
This PR resolves a usability issue where file and folder rename inputs fail validation silently and revert back to their original names. We now display appropriate toast messages explaining why the rename failed:
"Please enter a name"."Please enter a name"."Folder name cannot contain an extension"."Invalid file type...".Changes:
validateFileNameinFileNode.jsxto check and dispatchshowToastnotifications on validation failures.FileNode.unit.test.jsxto mockshowToastand assert that it is called on all validation failures.I have verified that this pull request:
npm run lint)npm run test)developbranch.