fix(client): validate file extension whitelist on rename#4175
Open
Dakshx07 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Fixes #4102
Currently, the p5.js Web Editor blocks invalid file extensions (such as
.obj) during file creation via the file modal. However, it does not perform the same validation when renaming a file. This allows users to bypass the file extension whitelist entirely by creating a valid file (e.g.,test.js) and then renaming it to an invalid extension (e.g.,test.obj).This PR fixes the bypass by validating file extensions against the whitelist during the rename operation.
Demo:
(No complex UI layout modifications—it triggers the pre-existing toast error message when an invalid extension is supplied during rename, identical to the behavior in the file creation modal, and reverts the file to its previous valid name).
Changes:
CREATE_FILE_REGEX(fromserver/utils/fileUtils.js) andshowToast(mapped asshowToastActionto resolve ESLintno-shadowrules).showToastin component props and declared it inpropTypes.validateFileNamemethod to check that renaming a file matchesCREATE_FILE_REGEX.showToastwith the translation keyNewFileModal.InvalidTypeand reverts the filename.showToastprop in the test setup..jsand.json) for renaming scenarios.cannot change to an invalid extensionto verify that invalid renames are blocked and triggershowToast.I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #4102