fix: move sinon, sinon-mongoose, jest-express, mongodb-memory-server …#3990
Open
avinxshKD wants to merge 1 commit intoprocessing:developfrom
Open
fix: move sinon, sinon-mongoose, jest-express, mongodb-memory-server …#3990avinxshKD wants to merge 1 commit intoprocessing:developfrom
avinxshKD wants to merge 1 commit intoprocessing:developfrom
Conversation
…to devDependencies
Contributor
Author
Contributor
|
I just went through the file and found that jsdom, csslint, htmlhint, jshint can also be moved to devDependencies (yeah, I rechecked they are used, my bad) |
Contributor
Author
|
Hey @yugalkaushik thanks for reviewing, also csslint, htmlhint, and jshint are actively used at runtime to lint user code in the editor, not test tooling. jsdom is the same. Moving those would break prod. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3937
sinon, sinon-mongoose, jest-express, and mongodb-memory-server were sitting in dependencies instead of devDependencies, meaning they get pulled in on every production install for no reason. Moved them where they belong.
Changes:
Moved 4 test-only packages from dependencies to devDependencies in package.json.
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #3937