Skip to content

fix: move sinon, sinon-mongoose, jest-express, mongodb-memory-server …#3990

Open
avinxshKD wants to merge 1 commit intoprocessing:developfrom
avinxshKD:fix/move-test-packages-to-devdependencies
Open

fix: move sinon, sinon-mongoose, jest-express, mongodb-memory-server …#3990
avinxshKD wants to merge 1 commit intoprocessing:developfrom
avinxshKD:fix/move-test-packages-to-devdependencies

Conversation

@avinxshKD
Copy link
Contributor

Fixes #3937

sinon, sinon-mongoose, jest-express, and mongodb-memory-server were sitting in dependencies instead of devDependencies, meaning they get pulled in on every production install for no reason. Moved them where they belong.

Changes:
Moved 4 test-only packages from dependencies to devDependencies in package.json.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • has no typecheck errors (npm run typecheck)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #3937
  • meets the standards outlined in the accessibility guidelines

@avinxshKD
Copy link
Contributor Author

avinxshKD commented Mar 11, 2026

Hey @raclim pls take a look, just moved the four packages to devDependencies, alphabetical order preserved.

Also what do you think of this #3922

Copy link
Contributor

@yugalkaushik yugalkaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yugalkaushik
Copy link
Contributor

yugalkaushik commented Mar 11, 2026

I just went through the file and found that jsdom, csslint, htmlhint, jshint can also be moved to devDependencies (yeah, I rechecked they are used, my bad)

@avinxshKD
Copy link
Contributor Author

Hey @yugalkaushik thanks for reviewing, also csslint, htmlhint, and jshint are actively used at runtime to lint user code in the editor, not test tooling. jsdom is the same. Moving those would break prod.
Happy to investigate further if needed though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test-only packages are in production dependencies

2 participants