Skip to content

chore(drive): close out prisma-next-data-contract#53

Merged
wmadden-electric merged 1 commit into
mainfrom
drive/close-prisma-next-data-contract
Jul 12, 2026
Merged

chore(drive): close out prisma-next-data-contract#53
wmadden-electric merged 1 commit into
mainfrom
drive/close-prisma-next-data-contract

Conversation

@wmadden-electric

Copy link
Copy Markdown
Contributor

Closes out the Prisma Next data contract project (Linear: "Prisma App: Prisma Next Data Contract"; slices: #44, #46; TML-3009/3011/3013 Done).

DoD verification

  1. Live typed round trip — met: pn-widgets example deploys to Prisma Cloud and round-trips through the PN typed client (E2E job green on feat(app-cloud): deploy migrate lowering for pnPostgres + pn-widgets example (slice 2) #46).
  2. Migrate-on-change + no-op redeploy — met: prisma-next-migrate.integration.test.ts ('re-run at the same ref → noop'; 'fresh DB + ref with invariants → migrate; re-run no-ops').
  3. No authored path → deploy fails, DB untouched — met: same file ('marker at a different hash with no authored path → fails, DB unchanged').
  4. Marker-mismatch warn-and-serve — amended by ADR-0022: schema correctness is deploy-time-only; hydrate does no runtime marker check (test: 'hydrate does no schema verification').
  5. Bare postgres() untouched and green — met: storefront-auth E2E green throughout.
  6. ADR-0022 merged; deferred design preserved — met: multi-contract/contract-space extension recorded in ADR-0022 §Alternatives (space id on the declaration, never topology-derived).

Final retro (lessons landed durably)

  • FT-5226 gotcha now points at the CI cold-connect canary that guards workaround removal (gotchas.md).
  • CI-refactor lesson (composite actions must carry script-consumed env vars) and the CONFLICTING-PR-stops-workflows trap landed in operator memory.

Migration & cleanup

  • Long-lived content already lives in docs/design (ADR-0022, amended ADR-0015/0017) — nothing to migrate.
  • Deferred items (multi-contract pickup prerequisite, dev-time sketch, factory rename) carried to .drive/deferred.md.
  • External-reference scan: clean. Transient .drive/projects/prisma-next-data-contract/ deleted.

🤖 Generated with Claude Code

DoD verified (all six items met; the marker-warn item was amended by
ADR-0022 to no-runtime-check, test-verified). Long-lived design already
lives in ADR-0022 including the deferred multi-contract extension; the
dev-time sketch and pickup prerequisites carried to .drive/deferred.md.
gotchas: FT-5226 entry now points at the CI canary that guards
workaround removal. Transient project artifacts deleted.

Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
@wmadden-electric wmadden-electric merged commit 9368339 into main Jul 12, 2026
14 checks passed
@wmadden-electric wmadden-electric deleted the drive/close-prisma-next-data-contract branch July 12, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants