Skip to content

chore: graduate primer_react_action_menu_display_in_viewport_inside_dialog#7700

Merged
liuliu-dev merged 5 commits intomainfrom
chore/graduate-actionmenu-ff
Mar 25, 2026
Merged

chore: graduate primer_react_action_menu_display_in_viewport_inside_dialog#7700
liuliu-dev merged 5 commits intomainfrom
chore/graduate-actionmenu-ff

Conversation

@francinelucca
Copy link
Member

@francinelucca francinelucca commented Mar 25, 2026

FF has been fully enabled in dotcom with no issues reported, graduating to default behavior

Changelog

Removed

  • primer_react_action_menu_display_in_viewport_inside_dialog, FF on behavior is now the default

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Mar 25, 2026

🦋 Changeset detected

Latest commit: 6cb7f10

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Mar 25, 2026
@github-actions
Copy link
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

@primer
Copy link
Contributor

primer bot commented Mar 25, 2026

🤖 Lint issues have been automatically fixed and committed to this PR.

@francinelucca francinelucca marked this pull request as ready for review March 25, 2026 15:54
@francinelucca francinelucca requested a review from a team as a code owner March 25, 2026 15:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Graduates the previously feature-flagged ActionMenu behavior so that displayInViewport becomes the default when an ActionMenu.Overlay is rendered inside a Dialog, aligning the library’s default behavior with the fully enabled dotcom rollout.

Changes:

  • Removed primer_react_action_menu_display_in_viewport_inside_dialog from DefaultFeatureFlags.
  • Updated ActionMenu.Overlay to default displayInViewport to true when inside DialogContext (unless explicitly provided).
  • Simplified/upgraded related unit tests and Storybook example to reflect the new default behavior.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/react/src/FeatureFlags/DefaultFeatureFlags.ts Removes the graduated flag from the default feature flag registry.
packages/react/src/ActionMenu/ActionMenu.tsx Makes “inside Dialog => displayInViewport” the default behavior without a feature flag.
packages/react/src/ActionMenu/ActionMenu.test.tsx Updates tests to cover the new default behavior and explicit prop overrides.
packages/react/src/ActionMenu/ActionMenu.examples.stories.tsx Removes FeatureFlags wrapper in the “InsideDialog” example now that behavior is default.

@github-actions github-actions bot requested a deployment to storybook-preview-7700 March 25, 2026 15:59 Abandoned
@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/16975

@primer-integration
Copy link

Integration test results from github/github-ui:

Passed  CI   Passed
Passed  VRT   Passed
Passed  Projects   Passed

All checks passed!

@liuliu-dev liuliu-dev added this pull request to the merge queue Mar 25, 2026
Merged via the queue into main with commit 91bf343 Mar 25, 2026
53 checks passed
@liuliu-dev liuliu-dev deleted the chore/graduate-actionmenu-ff branch March 25, 2026 18:19
@primer primer bot mentioned this pull request Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants