chore: graduate primer_react_action_menu_display_in_viewport_inside_dialog#7700
chore: graduate primer_react_action_menu_display_in_viewport_inside_dialog#7700liuliu-dev merged 5 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 6cb7f10 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
🤖 Lint issues have been automatically fixed and committed to this PR. |
There was a problem hiding this comment.
Pull request overview
Graduates the previously feature-flagged ActionMenu behavior so that displayInViewport becomes the default when an ActionMenu.Overlay is rendered inside a Dialog, aligning the library’s default behavior with the fully enabled dotcom rollout.
Changes:
- Removed
primer_react_action_menu_display_in_viewport_inside_dialogfromDefaultFeatureFlags. - Updated
ActionMenu.Overlayto defaultdisplayInViewporttotruewhen insideDialogContext(unless explicitly provided). - Simplified/upgraded related unit tests and Storybook example to reflect the new default behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react/src/FeatureFlags/DefaultFeatureFlags.ts | Removes the graduated flag from the default feature flag registry. |
| packages/react/src/ActionMenu/ActionMenu.tsx | Makes “inside Dialog => displayInViewport” the default behavior without a feature flag. |
| packages/react/src/ActionMenu/ActionMenu.test.tsx | Updates tests to cover the new default behavior and explicit prop overrides. |
| packages/react/src/ActionMenu/ActionMenu.examples.stories.tsx | Removes FeatureFlags wrapper in the “InsideDialog” example now that behavior is default. |
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/16975 |
FF has been fully enabled in dotcom with no issues reported, graduating to default behavior
Changelog
Removed
Rollout strategy
Testing & Reviewing
Merge checklist