Add ActionMenu.IconButton and ActionMenu.Anchor child validation#7640
Draft
Add ActionMenu.IconButton and ActionMenu.Anchor child validation#7640
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ActionMenu.Anchoraccepts arbitrary children, making it easy to wrap non-interactive elements (e.g.,<div>) and produce inaccessible markup. The most common use case forActionMenu.Anchoris wrappingIconButton, which should have a blessed shortcut.This PR adds two things:
ActionMenu.IconButton— syntactic sugar (likeActionMenu.Button) that correctly wires anIconButtonas the menu anchorActionMenu.Anchorchild validation — dev-only warning when the anchor child is not an interactive element, following the same pattern used inTooltipThe validation warns on non-interactive anchors but skips submenu contexts where
ActionList.Itemis the expected anchor.Changelog
New
ActionMenu.IconButton— shortcut for usingIconButtonas menu trigger, equivalent to wrapping it inActionMenu.AnchorActionMenuIconButtonPropstype exportconsole.warnwhenActionMenu.Anchorreceives a non-interactive child elementChanged
ActionMenu.Anchornow usesuseMergedRefsto combine an internal ref (for child validation) with the forwarded refRemoved
None
Rollout strategy
Testing & Reviewing
ActionMenu.IconButton(open/close, event handlers, id forwarding)<div>) and does not fire forButtonorIconButtonActionList.ItemanchorsActionMenu.IconButtonprop typesMerge checklist
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.