Skip to content

[Draft] Refactor voltage regulation in iidm #3699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
MatthieuSAUR wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

[Draft] Refactor voltage regulation in iidm #3699

MatthieuSAUR wants to merge 15 commits into from

Conversation

@MatthieuSAUR
Copy link
Contributor

@MatthieuSAUR MatthieuSAUR commented Dec 29, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

Fixes #3618

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

TODO

Other information:

@MatthieuSAUR MatthieuSAUR added IIDM Breaking Change API is broken Deprecated Methods have been deprecated labels Dec 29, 2025
@MatthieuSAUR MatthieuSAUR linked an issue Dec 29, 2025 that may be closed by this pull request
Refactor voltage regulation in IIDM #3618
Open
@MatthieuSAUR MatthieuSAUR changed the base branch from main to bump_iidm_to_1_16 January 5, 2026 13:38
@MatthieuSAUR
[3618] Light init WIP
0d15cfe 
Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
[3618] Add VoltageRegulationAdder and Builder
ba18799 
Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
[3618] Separate VoltageRegulationAdder and VoltageRegulationBuilder
6c6e672 
Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
[3618] Use Interface and implementation for VoltageRegulation
43f904d 
Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
[3618] Remove regulatingPoint from GeneratorImpl
03bdc1d 
Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
[3618] Use NetworkRef instead of Network
b01cd94 
Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
[3618] Remove setVoltageRegulation from VoltageRegulationHolder
adb7c56 
Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
[3618] Init VoltageRegulationSerDe
a588652 
Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
Bump IIDM to 1.16
ac7e87b 
Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
[3618] Add VoltageRegulation.targetValue in iidm for Generator
086482e 
Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
[3618] Complete xsd files with all attributes of the VoltageRegulatio…
1b756f4 
…n (Todo use required for targetValue, mode and regulating)

Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
[3618] Add regulationMode setter in VoltageRegulation
2418db5 
Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
[3618] Add some attributes and fix unit test (some test are disabled)
09b9375 
Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR MatthieuSAUR force-pushed the msa/3618-refactor-voltage-regulation-in-iidm branch from 9dece12 to 09b9375 Compare January 28, 2026 13:07
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 28, 2026

Quality Gate Passed Quality Gate passed

Issues
49 New issues
0 Accepted issues

Measures
0 Security Hotspots
81.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@MatthieuSAUR
[3618] Add 'targetDeadband' and 'slope' attributes
e16a085 
Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
[3618] Add 'terminal' into VoltageRegulation xsd and remove 'regulati…
65916d2 
…ngTerminal' from Generator xsd

Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
Base automatically changed from bump_iidm_to_1_16 to main January 29, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Breaking Change API is broken Deprecated Methods have been deprecated IIDM Release 03/2026

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor voltage regulation in IIDM

2 participants

@MatthieuSAUR