Fix streaming sync retry backoff#70
Open
joshuabrink wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes reconnection loops on error responses.
The retry loop in
StreamingSyncImplementationnever waited before reconnecting whenStreamingSyncIterationthrew.The
await DelayRetry()call lived inside aniterationResult != nullgate, anditerationResultis only assigned by a successful return from the iteration, so on the exception path the gate was always false and the loop reconnected immediately.AI Usage
Claude used for generating tests cases. Verified initial issue and fix correctness.