Skip to content

fix: fix integration test failures and warnings #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karawoo merged 3 commits into from
Feb 25, 2026
Merged

fix: fix integration test failures and warnings #509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93cd47c
add new API field
karawoo Feb 25, 2026
8b09a27
force logical
karawoo Feb 25, 2026
1a12eb1
fix vanity URL swap test
karawoo Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions R/ptype.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,9 @@ connectapi_ptypes <- list(
"created_time" = NA_datetime_,
"updated_time" = NA_datetime_,
"active_time" = NA_datetime_,
"confirmed" = NA,
"locked" = NA,
"confirmed" = FALSE,
"locked" = FALSE,
"external_id" = NA_character_,
"guid" = NA_character_
),
groups = tibble::tibble(
Expand Down
3 changes: 2 additions & 1 deletion tests/integrated/test-deploy.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,10 +315,11 @@ test_that("swap_vanity_urls works", {
# works with just one vanity url (content_b)
delete_vanity_url(tmp_content_a)
expect_null(get_vanity_url(tmp_content_a))
set_vanity_url(tmp_content_b, tmp_content_b_name)

swap_res3 <- swap_vanity_urls(tmp_content_a, tmp_content_b)

expect_identical(swap_res3$content_a, swap_res$content_a)
expect_identical(swap_res3$content_a, paste0("/", tmp_content_b_name, "/"))
expect_null(swap_res3$content_b)
})

Expand Down
5 changes: 1 addition & 4 deletions tests/integrated/test-get.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,7 @@ test_that("get_users works", {
users <- get_users(client)

expect_s3_class(users, c("tbl_df", "tbl", "data.frame"))
expect_equal(
purrr::map_chr(vctrs::vec_ptype(users), typeof),
purrr::map_chr(vctrs::vec_ptype(connectapi_ptypes$users), typeof)
)
expect_ptype_equal(users, connectapi_ptypes$users, exact = FALSE)

# Other tests create users, so specifying the exact number here is conditional
# on the contents of other tests and the order that tests run in.
Expand Down
5 changes: 1 addition & 4 deletions tests/integrated/test-lazy.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,7 @@ test_that("users works", {
expect_type(colnames(users), "character")
expect_gt(length(colnames(users)), 1)

expect_equal(
purrr::map_chr(vctrs::vec_ptype(users_local), typeof),
purrr::map_chr(vctrs::vec_ptype(connectapi_ptypes$users), typeof)
)
expect_ptype_equal(users_local, connectapi_ptypes$users, exact = FALSE)
})

test_that("usage_static works", {
Expand Down
Loading