Skip to content

Add content_guid filtering to get_usage()#508

Merged
karawoo merged 3 commits intomainfrom
guid_filter_hits
Feb 25, 2026
Merged

Add content_guid filtering to get_usage()#508
karawoo merged 3 commits intomainfrom
guid_filter_hits

Conversation

@jonkeane
Copy link
Collaborator

Intent

Now that connect accepts GUID filters on the hits endpoint, add that to the sdk

Approach

Checklist

  • Does this change update NEWS.md (referencing the connected issue if necessary)?
  • Does this change need documentation? Have you run devtools::document()?

Copy link
Collaborator

@karawoo karawoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a news bullet please?

@jonkeane
Copy link
Collaborator Author

Can we add a news bullet please?

Of course, I'll send one in a sec

The integration tests look unrelated but I don't know what's up with those: https://github.com/posit-dev/connectapi/actions/runs/22406879377/job/64869098248#step:6:530

══ Failed ══════════════════════════════════════════════════════════════════════
── 1. Failure ('test-get.R:13:3'): get_users works ─────────────────────────────
Expected `purrr::map_chr(vctrs::vec_ptype(users), typeof)` to equal `purrr::map_chr(vctrs::vec_ptype(connectapi_ptypes$users), typeof)`.
Differences:
`names(actual)[8:12]`:   "active_time" "confirmed" "locked" "external_id" "guid"
`names(expected)[8:11]`: "active_time" "confirmed" "locked"               "guid"

`actual[9:12]`:   "logical" "logical" "character" "character"
`expected[9:11]`: "logical" "logical" "character"            


── 2. Failure ('test-lazy.R:38:3'): users works ────────────────────────────────
Expected `purrr::map_chr(vctrs::vec_ptype(users_local), typeof)` to equal `purrr::map_chr(vctrs::vec_ptype(connectapi_ptypes$users), typeof)`.
Differences:
`names(actual)[8:12]`:   "active_time" "confirmed" "locked" "external_id" "guid"
`names(expected)[8:11]`: "active_time" "confirmed" "locked"               "guid"

`actual[9:12]`:   "logical" "logical" "character" "character"
`expected[9:11]`: "logical" "logical" "character"            

@karawoo
Copy link
Collaborator

karawoo commented Feb 25, 2026

They're failing on main too, it's due to a new field in the API responses. I'll fix separately, you can ignore.

@jonkeane
Copy link
Collaborator Author

Added news and a version guard

@karawoo
Copy link
Collaborator

karawoo commented Feb 25, 2026

@jonkeane can you update the unit tests so they have the right server version?

@karawoo
Copy link
Collaborator

karawoo commented Feb 25, 2026

@jonkeane actually if you don't mind, i'll just do it -- it'll be a quick fix and will unblock me moving forward with the cran release

@karawoo
Copy link
Collaborator

karawoo commented Feb 25, 2026

the failing test is fixed on main, everything else looks good. I'm going to merge this in order to proceed with the release.

@karawoo karawoo merged commit c559bd9 into main Feb 25, 2026
21 of 22 checks passed
@karawoo karawoo deleted the guid_filter_hits branch February 25, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants