Skip to content

remove map_dfr - fixes posit-dev/connectapi#422#496

Merged
karawoo merged 2 commits intoposit-dev:mainfrom
AntLP:remove-map_dfr-usage
Feb 9, 2026
Merged

remove map_dfr - fixes posit-dev/connectapi#422#496
karawoo merged 2 commits intoposit-dev:mainfrom
AntLP:remove-map_dfr-usage

Conversation

@AntLP
Copy link
Contributor

@AntLP AntLP commented Feb 6, 2026

Intent

As described in the issue, some functions had a dependency on dplyr through the use of purrr::map_df and purrr::map_dfr.

Fixes #422

Approach

Replaced the calls to purrr::map_df and purrr::map_dfr with a combination of purrr::map and purrr::list_rbind, which removes the dependency on dplyr.

I did not remove the purrr::map_dfr usages in the tests, dplyr is therefore still required to run the tests.

Checklist

  • Does this change update NEWS.md (referencing the connected issue if necessary)?
  • Does this change need documentation? Have you run devtools::document()?

@AntLP AntLP marked this pull request as ready for review February 6, 2026 19:14
@karawoo
Copy link
Collaborator

karawoo commented Feb 9, 2026

Thank you for this contribution! The failing Ci issues all appear to be due to repository secrets not being available to forks; I've tried your changes locally and everything looks good. I'll merge this and if any CI stuff continues to fail I'll fix that on my own as a followup.

@karawoo karawoo merged commit dc00c00 into posit-dev:main Feb 9, 2026
10 of 22 checks passed
@karawoo karawoo mentioned this pull request Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove usage of purrr::map_dfr to remove implicit dplyr dependency

2 participants