Skip to content

Improve raise-message for better debugging #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bouwew merged 6 commits into from
Mar 4, 2026
Merged

Improve raise-message for better debugging #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
32a310e
Correct max version for 2015-9-18 firmware
bouwew Mar 4, 2026
3febf77
Fix
bouwew Mar 4, 2026
4565308
Extend MessageError raise-message
bouwew Mar 4, 2026
d69f967
Ruffed
bouwew Mar 4, 2026
da6c5f2
Update CHANGELOG
bouwew Mar 4, 2026
5cc8be5
Set release-version to v0.47.3
bouwew Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
# Changelog

## Ongoing updates
## v0.47.3 - 2026-03-04

- PR [418](https://github.com/plugwise/python-plugwise-usb/pull/418): Improve raise-message for better debugging
Copy link

@coderabbitai coderabbitai bot Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Changelog entry should include the firmware support bump from this PR.

The current note mentions only the raise-message improvement, but the PR objective also includes the 2015-09-18 firmware max-version update to 2.6. Please include that for accurate release traceability.

✏️ Suggested changelog tweak 
-- PR [418](https://github.com/plugwise/python-plugwise-usb/pull/418): Improve raise-message for better debugging
+- PR [418](https://github.com/plugwise/python-plugwise-usb/pull/418): Improve raise-message for better debugging; update 2015-09-18 firmware max supported Zigbee protocol from 2.5 to 2.6
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- PR [418](https://github.com/plugwise/python-plugwise-usb/pull/418): Improve raise-message for better debugging
- PR [418](https://github.com/plugwise/python-plugwise-usb/pull/418): Improve raise-message for better debugging; update 2015-09-18 firmware max supported Zigbee protocol from 2.5 to 2.6
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@CHANGELOG.md` at line 5, Update the CHANGELOG entry for PR `#418` to include
the firmware support bump: append or modify the line "- PR
[418](https://github.com/plugwise/python-plugwise-usb/pull/418): Improve
raise-message for better debugging" to also mention the 2015-09-18 firmware
max-version update to 2.6 (e.g., "..., and bump 2015-09-18 firmware max-version
to 2.6") so the changelog reflects both the raise-message improvement and the
firmware support change.

- PR [405](https://github.com/plugwise/python-plugwise-usb/pull/405): Fix recent Ruff errors

## v0.47.2 - 2026-01-29
Expand Down
2 changes: 1 addition & 1 deletion plugwise_usb/connection/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ async def send(
return await self._queue.submit(request)
try:
return await self._queue.submit(request)
except NodeError, StickError:
except (NodeError, StickError):
return None

def _reset_states(self) -> None:
Expand Down
4 changes: 3 additions & 1 deletion plugwise_usb/messages/requests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,7 +742,9 @@ def __init__(
self.priority = Priority.HIGH
if protocol_version < 2.0:
# FIXME: Define "absoluteHour" variable
raise MessageError("Unsupported version of CircleClockSetRequest")
raise MessageError(
f"Unsupported version ({protocol_version}) of CircleClockSetRequest for {self.mac_decoded}"
)

passed_days = dt.day - 1
month_minutes = (
Expand Down
2 changes: 1 addition & 1 deletion plugwise_usb/nodes/helpers/firmware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class SupportedVersions(NamedTuple):
# Proto release
datetime(2015, 6, 16, 21, 9, 10, tzinfo=UTC): SupportedVersions(min=2.0, max=2.6),
datetime(2015, 6, 18, 14, 0, 54, tzinfo=UTC): SupportedVersions(min=2.0, max=2.6),
datetime(2015, 9, 18, 8, 53, 15, tzinfo=UTC): SupportedVersions(min=2.0, max=2.5),
datetime(2015, 9, 18, 8, 53, 15, tzinfo=UTC): SupportedVersions(min=2.0, max=2.6),
Copy link
Contributor

@dirixmjm dirixmjm Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering whether it makes to have a "max" version at all for some functionality?
On the other hand, we don't really expect any firmware updates anyway.

# New Flash Update
datetime(2017, 7, 11, 16, 6, 59, tzinfo=UTC): SupportedVersions(min=2.0, max=2.6),
}
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"

[project]
name = "plugwise_usb"
version = "0.47.2"
version = "0.47.3"
license = "MIT"
keywords = ["home", "automation", "plugwise", "module", "usb"]
classifiers = [
Expand Down
Loading