-
Notifications
You must be signed in to change notification settings - Fork 317
Refactor font rendering pipeline, remove font-kit and pathfinder
#736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pbdeuchler
wants to merge
23
commits into
plotters-rs:master
Choose a base branch
from
pbdeuchler:pbd/migrate_to_harfrust
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
c740d70
feat(font): replace font-kit/ab_glyph stack with fontique/harfrust/sk…
pbdeuchler 3187a6f
test(font): cover the new context pipeline against the bitmap backend
pbdeuchler ac403d0
refactor(font): drop the legacy native backends and their dependencies
pbdeuchler de1acd8
fix(font): re-export InvalidFont alongside register_font
pbdeuchler 0a57bb1
cr: address Claude code review, remove random crufty API surface, fix…
pbdeuchler 0df95d1
chore(ci): install libfontconfig-dev on Linux runners
pbdeuchler 6d8179a
feat(font): add dynamic_font example, seal FontContext as pub(crate)
pbdeuchler 11f700d
fix(font): add skrifa hinting and subpixel-aware rasterization
pbdeuchler 681dc87
chore: remove LLM cruft comments
pbdeuchler 69719d7
chore: remove builder and pointless inner struct from earlier versions
pbdeuchler a11e987
fix: fix example and bugs preventing them from running around type hi…
pbdeuchler 8d3d634
chore: once again remove LLM comment cruft
pbdeuchler a895174
fix: kerning baseline fix and quick compilation fix since somehow we …
pbdeuchler f24a7e8
nit: make engine declarations a bit more readable
pbdeuchler dbb1360
nit: invert if for better readability
pbdeuchler 6fa6833
chore: fix tests by creating font family fallback behavior, mimicking…
pbdeuchler f83f203
chore: screwed up submodules somehow, fixing
pbdeuchler d42ea18
nit: flatten Result<Option<>> to just Option<> per cr comments
pbdeuchler 21e85ba
chore: check in fonts used in dynamic_font example
pbdeuchler de4f0aa
fix(font): push the chart's font context when laying out series labels
pbdeuchler c75959e
feat(examples): add modern.rs dark-theme line chart example
pbdeuchler 0d7198c
Update plotters/src/style/font/system.rs
pbdeuchler 909e82b
Update plotters/src/style/font/context.rs
pbdeuchler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| [submodule "plotters-doc-data"] | ||
| path = plotters/plotters-doc-data | ||
| url = https://github.com/38/plotters-doc-data | ||
| [submodule "plotters/plotters-doc-data"] | ||
| path = plotters/plotters-doc-data | ||
| url = git@github.com:plotters-rs/plotters-doc-data.git |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ab_glyph doesn't add the ab_glyph dep?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not anymore, it all goes through the same pipeline.
ab_glyphjust turns off system font discovery now.