Skip to content

Fix accidental creation of js/ directory under site-packages/ when installing Plotly#5587

Merged
emilykl merged 1 commit intomainfrom
fix-5584-2
May 1, 2026
Merged

Fix accidental creation of js/ directory under site-packages/ when installing Plotly#5587
emilykl merged 1 commit intomainfrom
fix-5584-2

Conversation

@emilykl
Copy link
Copy Markdown
Contributor

@emilykl emilykl commented Apr 30, 2026

Link to issue

Closes #5584

Description of change

Fixes issue since Plotly 6.7.0, introduced by #5540, where pip install plotly would unintentionally create a js/ directory under site-packages/, interfering with any other package which might use the js/ name.

Demo

N/A

Testing strategy

To reproduce the issue:

  1. Create a fresh Python virtual environment
  2. Run pip install plotly==6.7.0 (or uv pip install ...)
  3. Notice that the following directory exists: $VENV_ROOT/lib/pythonX.Y/site-packages/js

To verify that this PR fixes the issue:

  1. Check out this branch
  2. Run python -m build from the root folder, and make sure it runs without error
  • Verify that new dist/plotly-6.7.0.tar.gz and dist/plotly-6.7.0-py3-none-any.whl files are created
  1. Create a fresh Python virtual environment
  2. Run pip install dist/plotly-6.7.0-py3-none-any.whl
  3. Verify that $VENV_ROOT/lib/pythonX.Y/site-packages/js DOES NOT exist
  4. Verify that $VENV_ROOT/share/jupyter/labextensions/jupyterlab-plotly/install.json DOES exist
  5. To test installing the tar file, repeat steps 4-7 replacing the .whl file path with the .tar.gz file path

Guidelines

@emilykl emilykl merged commit 4d590f3 into main May 1, 2026
25 checks passed
@emilykl emilykl deleted the fix-5584-2 branch May 1, 2026 14:27
@mgorny
Copy link
Copy Markdown
Contributor

mgorny commented May 1, 2026

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: plotly is installing js top-level package with data files

3 participants