Skip to content

Refactor autoshapes to use shape.label for vline/hline/vrect/hrect #5444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nochinxx wants to merge 13 commits into
base: main
Choose a base branch
from
+515 −22
Open

Refactor autoshapes to use shape.label for vline/hline/vrect/hrect #5444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1d88dcd
refactor/autoshapes-use-shape-label: created helper _coerce_shape_lab…
nochinxx Nov 17, 2025
c5bdc3e
BaseFigure.add_vline: coerce legacy annotation_* kwargs into shape.la…
nochinxx Nov 17, 2025
02b7272
-chore(autoshapes): add legacy→label shim (non-destructive) and line-…
nochinxx Nov 17, 2025
274d72e
chore: ignore generated remoteEntry JS bundles
nochinxx Nov 17, 2025
08a318d
preserve legacy annotation for add_vline
chanlii Dec 2, 2025
d7f5fb8
refactor (add_vrect): Create a single labeled shape and map legacy an…
chanlii Dec 2, 2025
84cd455
Migrate add_hrect from annotation to shape/label
chanlii Dec 6, 2025
1010346
refactored and change the comments of hline,vrect,hrect
nochinxx Dec 6, 2025
7380077
style: format basedatatypes with ruff
nochinxx Mar 23, 2026
adb386b
test: verify shape.label behavior for autoshapes
nochinxx Mar 23, 2026
4fc3b49
style: format autoshapes tests
nochinxx Mar 23, 2026
60ef849
Merge branch 'main' into refactor/autoshapes-use-shape-label
emilykl Mar 25, 2026
10e5cac
chore: update changelog to include migration of shape helpers to use …
nochinxx Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,10 @@ doc/check-or-enforce-order.py
tests/percy/*.html
tests/percy/pandas2/*.html
test_path.png

# Ignore generated Plotly.js assets
package.json
static/remoteEntry.*.js
remoteEntry.*.js
plotly/labextension/package.json
plotly/labextension/static/remoteEntry.3a317cf6fef461b227b4.js
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).

### Added
- Add `facet_row` support to `px.imshow` for creating subplots along an additional dimension [[#5445](https://github.com/plotly/plotly.py/pull/5445)]
- Begin migrating `add_vline`, `add_hline`, `add_vrect`, `add_hrect` to use native `layout.shape.label`; the new `label=` parameter is now supported on all four helpers, and legacy `annotation_*` kwargs are forwarded to `shape.label` with a `FutureWarning` [[#5373](https://github.com/plotly/plotly.py/pull/5373)]

### Fixed
- Update `numpy.percentile` syntax to stop using deprecated alias [[5483](https://github.com/plotly/plotly.py/pull/5483)], with thanks to @Mr-Neutr0n for the contribution!
Expand Down
Loading