Skip to content

better-pyvenv-fix#355

Merged
jhheider merged 1 commit into
mainfrom
better-pyvenv-fix
Jun 13, 2026
Merged

better-pyvenv-fix#355
jhheider merged 1 commit into
mainfrom
better-pyvenv-fix

Conversation

@jhheider

Copy link
Copy Markdown
Contributor

--copies breaks darwin:

+ git tag -a 9.1.0 -m 'Version 9.1.0' --force
+ unset GIT_DIR
+ '[' '' = poetry ']'
+ python -m venv --copies /opt/pytest.org/v9.1.0+brewing/venv
Error: Command '['/opt/pytest.org/v9.1.0+brewing/venv/bin/python', '-m', 'ensurepip', '--upgrade', '--default-pip']' died with <Signals.SIGABRT: 6>.

Copilot AI review requested due to automatic review settings June 13, 2026 21:04

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a macOS/Darwin failure when creating Python virtual environments with python -m venv --copies, by selecting a platform-appropriate venv creation mode in bkpyvenv.

Changes:

  • Use python -m venv --copies on Linux to avoid absolute-symlink relocation issues.
  • Use default python -m venv on non-Linux (eg macOS) to avoid --copies breaking signed/framework Python binaries.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread libexec/bkpyvenv
Comment on lines +50 to +53
*)
# macOS: --copies breaks signed/framework python binaries.
# The pkgm-relocation problem #8487 doesn't apply on darwin in
# the same way (different runtime resolution)
@jhheider jhheider merged commit 044f4fb into main Jun 13, 2026
39 checks passed
@jhheider jhheider deleted the better-pyvenv-fix branch June 13, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants