chore: release v1.4.4#38
Conversation
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
WalkthroughVersion bumped from 1.4.3 to 1.4.4 in ChangesVersion 1.4.4 Release
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
This PR increments the package version to v1.4.4, but it is currently not ready for merging. There is a significant gap between the intent expressed in the CHANGELOG and the code actually provided. While the version string in 'src/modelinfo/init.py' was updated, the implementations for batch-size flags, timeout configurations, HF_ENDPOINT support, and Intel GPU discovery are entirely missing from the diff. Additionally, an acceptance criterion involving 'pyproject.toml' was not met as that file was not included in the changes. Codacy results indicate the project is up to standards, but this is likely due to the lack of logic changes rather than the quality of the new features.
About this PR
- The PR description and CHANGELOG describe significant new features (batch-size flags, Intel GPU discovery, HF_ENDPOINT support) and bug fixes (E402 warnings) that are completely absent from the current diff. Please ensure all implementation logic and corresponding tests are included.
- The PR checklist indicates that tests were added to cover these changes, but no test files are included in the PR. Please provide unit/integration tests for the new CLI flags and GPU discovery logic.
Test suggestions
- Verify that the CLI --version flag correctly reports '1.4.4'.
- Validate that the --batch-size flag is accepted and defaults to 1.
- Validate that the --timeout flag is accepted and defaults to 10s.
- Verify Intel GPU discovery via xpu-smi works as described in the changelog.
- Ensure the HF_ENDPOINT environment variable correctly overrides the default Hugging Face endpoint.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that the CLI --version flag correctly reports '1.4.4'.
2. Validate that the --batch-size flag is accepted and defaults to 1.
3. Validate that the --timeout flag is accepted and defaults to 10s.
4. Verify Intel GPU discovery via xpu-smi works as described in the changelog.
5. Ensure the HF_ENDPOINT environment variable correctly overrides the default Hugging Face endpoint.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
|
|
||
| ### Changed | ||
| - Reorganized local GPU discovery helpers in `hardware.py`. | ||
| - Cleaned up test parser module imports to resolve E402 warnings. |
There was a problem hiding this comment.
🟡 MEDIUM RISK
This changelog entry refers to import cleanups that are not included in the current diff. Ensure all functional changes mentioned in the changelog are committed.
Summary
This PR prepares the release of version v1.4.4 by bumping the version numbers and updating the changelog.
Motivation & Context
Bumps version constants and records changes since v1.4.3 in
CHANGELOG.mdto release new features (batch size option, custom endpoints, fetch timeouts, GPU suggestions, and Intel GPU discovery) to users.Type of Change
How Has This Been Tested?
Verified by running the test suite to ensure all unit tests pass.
Checklist
Summary by CodeRabbit
New Features
Bug Fixes
Chores