feat(search): migrate to unified index and add category chip#677
feat(search): migrate to unified index and add category chip#677
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello @Yuiham, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the search experience by transitioning to a unified search index, which simplifies the underlying search logic and improves result presentation. The introduction of category chips directly on search results enhances user understanding and navigation, making it easier to identify the relevance of each search hit at a glance. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request migrates the site-wide search to a unified Algolia index, simplifying the search implementation, introducing shared/utils/searchCategory.ts for URL-based category resolution, and enhancing the UI with a category chip in search results. A critical finding is a medium-severity Cross-Site Scripting (XSS) vulnerability in src/components/Search/Results.tsx due to the use of dangerouslySetInnerHTML to render highlighted search results from Algolia, which requires sanitization as a best practice. On a positive note, the changes also improve security by removing user-controlled parameters from the search index selection logic, and there is a minor suggestion to improve type safety.
51b689b to
1532eaf
Compare
Summary
en-tidb-all-stable,zh-tidb-all-stable), and remove per-doc-type/version index routing/searchquery/state handling to only useqsrc/shared/utils/searchCategory.tsto normalize search hit URLs and infer category from path prefixesWhy
Notes
/searchno longer depends ontypeandversionquery paramsDocSearchTemplateValidation