Skip to content

Fix broken external documentation links#23163

Open
wenxiaojie1 wants to merge 4 commits into
pingcap:masterfrom
wenxiaojie1:fix/broken-links-23161
Open

Fix broken external documentation links#23163
wenxiaojie1 wants to merge 4 commits into
pingcap:masterfrom
wenxiaojie1:fix/broken-links-23161

Conversation

@wenxiaojie1

Copy link
Copy Markdown

Fixes #23161.

This updates the two external documentation links reported by the broken-link checker:

  • Replaces the removed LangChain TiDB Vector sample page with the current TiDBVectorStore API reference.
  • Replaces the Debezium MySQL 2.4 data-type mapping URL with the stable documentation URL.

Validation:

  • Verified both replacement URLs return HTTP 200.

@ti-chi-bot

ti-chi-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign breezewish for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Jun 29, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown

Welcome @wenxiaojie1!

It looks like this is your first PR to pingcap/docs 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/docs. 😃

@ti-chi-bot

ti-chi-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown

Hi @wenxiaojie1. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. missing-translation-status This PR does not have translation status info. labels Jun 29, 2026
@pingcap-cla-assistant

pingcap-cla-assistant Bot commented Jun 29, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 29, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates documentation links in the LangChain integration and TiCDC Debezium guides. The review feedback suggests minor improvements to align with the style guide, including enclosing the TiDBVectorStore class name in backticks and removing filler words like 'basically' and 'generally' for better clarity.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

> **Tip**
>
> You can view the complete [sample code](https://docs.langchain.com/oss/python/integrations/vectorstores/tidb_vector) in LangChain documentation.
> You can view the complete [TiDBVectorStore API reference](https://reference.langchain.com/python/integrations/langchain_community.vectorstores.tidb_vector.TiDBVectorStore/) in LangChain documentation.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

According to the repository style guide, code snippets, class names, and technical identifiers should be enclosed in backticks for clarity.

Suggested change
> You can view the complete [TiDBVectorStore API reference](https://reference.langchain.com/python/integrations/langchain_community.vectorstores.tidb_vector.TiDBVectorStore/) in LangChain documentation.
> You can view the complete [`TiDBVectorStore` API reference](https://reference.langchain.com/python/integrations/langchain_community.vectorstores.tidb_vector.TiDBVectorStore/) in LangChain documentation.
References
  1. Code snippets, command names, options, and paths should be in backticks. (link)

Comment thread ticdc/ticdc-debezium.md Outdated
### Data type mapping

The data format mapping in the TiCDC Debezium message basically follows the [Debezium data type mapping rules](https://debezium.io/documentation/reference/2.4/connectors/mysql.html#mysql-data-types), which is generally consistent with the native message of the Debezium Connector for MySQL. However, for some data types, the following differences exist between TiCDC Debezium and Debezium Connector messages:
The data format mapping in the TiCDC Debezium message basically follows the [Debezium data type mapping rules](https://debezium.io/documentation/reference/stable/connectors/mysql.html#mysql-data-types), which is generally consistent with the native message of the Debezium Connector for MySQL. However, for some data types, the following differences exist between TiCDC Debezium and Debezium Connector messages:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

To improve clarity and adhere to the writing principles, we should avoid unnecessary filler words like 'basically' and 'generally'.

Suggested change
The data format mapping in the TiCDC Debezium message basically follows the [Debezium data type mapping rules](https://debezium.io/documentation/reference/stable/connectors/mysql.html#mysql-data-types), which is generally consistent with the native message of the Debezium Connector for MySQL. However, for some data types, the following differences exist between TiCDC Debezium and Debezium Connector messages:
The data format mapping in the TiCDC Debezium message follows the [Debezium data type mapping rules](https://debezium.io/documentation/reference/stable/connectors/mysql.html#mysql-data-types), which is consistent with the native message of the Debezium Connector for MySQL. However, for some data types, the following differences exist between TiCDC Debezium and Debezium Connector messages:
References
  1. Avoid unnecessary words and repetition. (link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. missing-translation-status This PR does not have translation status info. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken Link Detected

1 participant