config: fix heading hierarchy for sub-section levels in tidb-configuration-file.md#23160
Conversation
Change sub-section headings from ## to ### to properly reflect the config key hierarchy: - ## log.file → ### log.file (child of ## log) - ## opentracing.sampler → ### opentracing.sampler - ## opentracing.reporter → ### opentracing.reporter - ## tikv-client.copr-cache → ### tikv-client.copr-cache
There was a problem hiding this comment.
Code Review
This pull request adjusts several section headings in tidb-configuration-file.md (specifically log.file, opentracing.sampler, opentracing.reporter, and tikv-client.copr-cache) from H2 (##) to H3 (###) to improve the document structure. The review feedback points out that while these changes are correct, the nested configuration options under opentracing.sampler, opentracing.reporter, and tikv-client.copr-cache are still using H3 (###) headings and should be updated to H4 (####) to maintain a proper heading hierarchy.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
[LGTM Timeline notifier]Timeline:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Synced from: pingcap/docs#23160 Target PR: pingcap#21748 AI Provider: azure Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
In response to a cherrypick label: new pull request created to branch |
What is changed, added or deleted? (Required)
Fix heading hierarchy in tidb-configuration-file.md for sub-section levels that incorrectly used
##instead of###:## log.file→### log.file(child of## log)## opentracing.sampler→### opentracing.sampler(child of## opentracing)## opentracing.reporter→### opentracing.reporter(child of## opentracing)## tikv-client.copr-cache→### tikv-client.copr-cache(child of## tikv-client)These dotted config key names indicate they belong to parent sections, so they should be rendered as sub-headings.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?