cloud: add private link firewall rules for clusters on AWS and Alibaba Cloud#22650
cloud: add private link firewall rules for clusters on AWS and Alibaba Cloud#22650hfxsd wants to merge 7 commits intopingcap:release-8.5from
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds a new step, 'Authorize your private endpoint in TiDB Cloud', to the documentation for setting up private endpoint connections on Alibaba Cloud and TiDB Cloud Serverless. The review feedback identifies several issues: a copy-paste error referencing AWS in the Alibaba Cloud guide, inconsistent anchor links and text in the tables of contents, and heading punctuation that violates the repository style guide.
tidb-cloud/set-up-private-endpoint-connections-on-alibaba-cloud.md
Outdated
Show resolved
Hide resolved
tidb-cloud/set-up-private-endpoint-connections-on-alibaba-cloud.md
Outdated
Show resolved
Hide resolved
tidb-cloud/set-up-private-endpoint-connections-on-alibaba-cloud.md
Outdated
Show resolved
Hide resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
… into connect-via-ali-and-aws
|
@sanshuiyijing: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
tidb-cloud/set-up-private-endpoint-connections-on-alibaba-cloud.md
Outdated
Show resolved
Hide resolved
tidb-cloud/set-up-private-endpoint-connections-on-alibaba-cloud.md
Outdated
Show resolved
Hide resolved
tidb-cloud/set-up-private-endpoint-connections-on-alibaba-cloud.md
Outdated
Show resolved
Hide resolved
tidb-cloud/set-up-private-endpoint-connections-on-alibaba-cloud.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
|
/retest |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?