Skip to content

Premium public review#22638

Open
qqqdan wants to merge 2 commits intorelease-8.5from
premium-public-review
Open

Premium public review#22638
qqqdan wants to merge 2 commits intorelease-8.5from
premium-public-review

Conversation

@qqqdan
Copy link
Copy Markdown
Contributor

@qqqdan qqqdan commented Mar 26, 2026

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qqqdan qqqdan requested a review from Oreoxmt March 26, 2026 21:12
@qqqdan qqqdan self-assigned this Mar 26, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Mar 26, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign csuzhangxc for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 26, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the new Premium plan to TiDB Cloud documentation. Key changes include adding a Premium column to the feature support table, providing a detailed description of the plan's benefits, and updating its status to public preview. Review feedback suggests verifying a potential status regression for database audit logging and recommends rewriting feature descriptions to use the second person and active voice for improved clarity.

<td>Database audit logging</td>
<td style="text-align:center; font-size: 14px;">❌</td>
<td style="text-align:center;">🔒</td>
<td style="text-align:center;">🚧</td>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The status for "Database audit logging" on the Essential plan has changed from 🔒 (private preview) to 🚧 (under development). This seems like a feature regression. Could you please confirm if this change is intentional? According to the legend, 🚧 means "under development", which is usually a step before "private preview".

References
  1. The style guide requires technical accuracy. The change from 'private preview' to 'under development' for a feature seems to be a regression and might be technically inaccurate. (link)

Comment on lines +90 to +94
- **Instant elasticity**: handles massive and unpredictable traffic spikes by scaling computing resources automatically, ensuring zero performance bottlenecks during peak demands.
- **Unlimited growth**: architected for virtually unlimited expansion in both storage and throughput, allowing your database to scale seamlessly alongside your business without physical infrastructure constraints.
- **Zero-infrastructure management**: provides a fully managed, "zero-touch" operational experience, eliminating the complexity of manual scaling, patching, or capacity planning.
- **Predictable pricing**: billed based on storage and Request Capacity Units (RCUs), offering transparent, usage-based pricing that scales with your needs, so you only pay for what you use without surprises.
- **Advanced security and compliance**: incorporates our most stringent security standards, including advanced encryption, CMEK, private networking options, and comprehensive compliance certifications to protect your most sensitive data.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

To align with the style guide's preference for using the second person ("you") and active voice, I suggest rewriting these feature descriptions for better clarity and a more direct address to the user. This will make the benefits of the Premium plan clearer.

Suggested change
- **Instant elasticity**: handles massive and unpredictable traffic spikes by scaling computing resources automatically, ensuring zero performance bottlenecks during peak demands.
- **Unlimited growth**: architected for virtually unlimited expansion in both storage and throughput, allowing your database to scale seamlessly alongside your business without physical infrastructure constraints.
- **Zero-infrastructure management**: provides a fully managed, "zero-touch" operational experience, eliminating the complexity of manual scaling, patching, or capacity planning.
- **Predictable pricing**: billed based on storage and Request Capacity Units (RCUs), offering transparent, usage-based pricing that scales with your needs, so you only pay for what you use without surprises.
- **Advanced security and compliance**: incorporates our most stringent security standards, including advanced encryption, CMEK, private networking options, and comprehensive compliance certifications to protect your most sensitive data.
- **Instant elasticity**: Automatically scales computing resources to handle massive and unpredictable traffic spikes, ensuring you experience zero performance bottlenecks during peak demands.
- **Unlimited growth**: Allows your database to scale seamlessly alongside your business with a virtually unlimited expansion in both storage and throughput, without physical infrastructure constraints.
- **Zero-infrastructure management**: Provides you with a fully managed, "zero-touch" operational experience, eliminating the complexity of manual scaling, patching, or capacity planning.
- **Predictable pricing**: Offers transparent, usage-based pricing that scales with your needs. You are billed based on storage and Request Capacity Units (RCUs), so you only pay for what you use without surprises.
- **Advanced security and compliance**: Incorporates our most stringent security standards to protect your most sensitive data, including advanced encryption, CMEK, private networking options, and comprehensive compliance certifications.
References
  1. The style guide recommends writing in the second person ('you') and using active voice to address users directly. The current text uses a mix of passive voice and third person. (link)

@Oreoxmt Oreoxmt added translation/no-need No need to translate this PR. area/tidb-cloud This PR relates to the area of TiDB Cloud. for-cloud-release This PR is related to TiDB Cloud release. labels Mar 27, 2026
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Mar 27, 2026
@Oreoxmt Oreoxmt self-assigned this Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tidb-cloud This PR relates to the area of TiDB Cloud. for-cloud-release This PR is related to TiDB Cloud release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants